Skip to content

PMM-14006 Fix for disabled examples in perfschema. #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

PMM-14006 Fix for disabled examples in perfschema. #4635

merged 3 commits into from
Oct 16, 2025

Conversation

@JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Oct 8, 2025 •
edited by matejkubinec
Loading

@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.58%. Comparing base (d7961ad) to head (7c50582).
⚠️ Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
agent/agents/mysql/perfschema/perfschema.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #4635      +/-   ##
==========================================
+ Coverage   44.53%   44.58%   +0.04%     
==========================================
  Files         363      363              
  Lines       45706    45640      -66     
==========================================
- Hits        20355    20348       -7     
+ Misses      23691    23632      -59     
  Partials     1660     1660
Flag Coverage Δ
agent 53.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review October 8, 2025 09:27
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner October 8, 2025 09:27
@JiriCtvrtka JiriCtvrtka requested review from a team, BupycHuk, ademidoff and idoqo and removed request for a team October 8, 2025 09:27
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) October 16, 2025 12:50
@JiriCtvrtka JiriCtvrtka merged commit f16bb34 into v3 Oct 16, 2025
24 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-14006-disabled-perfschema-examples-fix branch October 16, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ademidoff ademidoff ademidoff approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@idoqo idoqo Awaiting requested review from idoqo idoqo is a code owner automatically assigned from percona/pmm-review-be

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JiriCtvrtka @ademidoff @BupycHuk